Overview
| Comment: | fixed bug with runs summary tab when using dbfile modified time timestamp optimization; not really related to that, but to original timestamp code that wrapped get-test-data clashing with the proper functioning of get-tests-for-run-duplicate; now there is a bug in launching test control panel from runs-summary-tab matrix cells |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | runs-summary-context-menu |
| Files: | files | file ages | folders |
| SHA1: |
028819adf7fd8fa10794fe34cb80d785 |
| User & Date: | bb on 2016-09-17 00:46:42 |
| Other Links: | branch diff | manifest | tags |
Context
|
2016-09-17
| ||
| 01:48 | cleaned up some debug statements; I think runs-summary click-cb issue may be specific to my host. Made opinionated changes to context menu Closed-Leaf check-in: db71f6e3c0 user: bb tags: runs-summary-context-menu | |
| 00:46 | fixed bug with runs summary tab when using dbfile modified time timestamp optimization; not really related to that, but to original timestamp code that wrapped get-test-data clashing with the proper functioning of get-tests-for-run-duplicate; now there is a bug in launching test control panel from runs-summary-tab matrix cells check-in: 028819adf7 user: bb tags: runs-summary-context-menu | |
| 00:22 | enabled override of num-to-get in dboard:get-tests-for-run-duplicate; overriding from 100 to 1000 masks foregoing issue check-in: 759c9e1976 user: bb tags: runs-summary-context-menu | |
Changes
Modified dashboard.scm from [953e897ae3] to [243eb78366].
| ︙ | ︙ | |||
1489 1490 1491 1492 1493 1494 1495 |
(else #f)))))))
(define (dashboard:run-id->tests-mindat run-id tabdat runs-hash)
(let* ((run (hash-table-ref/default runs-hash run-id #f))
(key-vals (rmt:get-key-vals run-id))
(testnamepatt (or (dboard:tabdat-test-patts tabdat) "%/%"))
| > > | | | > | < | | | | < > | | | | 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 |
(else #f)))))))
(define (dashboard:run-id->tests-mindat run-id tabdat runs-hash)
(let* ((run (hash-table-ref/default runs-hash run-id #f))
(key-vals (rmt:get-key-vals run-id))
(testnamepatt (or (dboard:tabdat-test-patts tabdat) "%/%"))
(tests-ht (dboard:get-tests-for-run-duplicate tabdat run-id run testnamepatt key-vals))
(tests-dat (dashboard:tests-ht->tests-dat tests-ht))
;; (tests-dat (if (or (not run-id)
;; (configf:lookup *configdat* "setup" "do-not-use-db-file-timestamps")
;; (not (hash-table-exists? (dboard:tabdat-last-test-dat tabdat) run-id))
;; )
;; (begin
;; (BB> "before run-status gtfrd")
;; (let* ((tests-ht (dboard:get-tests-for-run-duplicate tabdat run-id run testnamepatt key-vals))
;; (res (dashboard:tests-ht->tests-dat tests-ht)) ;; yes, we lose the order by making a hash table and reordering it here for the matrix... Optimize this if it slows stuff down.
;; )
;; (BB> "after run-status gtfrd")
;; res))
;; (hash-table-ref (dboard:tabdat-last-test-dat tabdat) run-id)))
(tests-mindat (dcommon:minimize-test-data tests-dat))) ;; reduces data for display
(dboard:tabdat-last-runs-update-set! tabdat (- (current-seconds) 2))
(hash-table-set! (dboard:tabdat-last-test-dat tabdat) run-id tests-dat)
(hash-table-set! (dboard:tabdat-run-update-times tabdat) run-id (- (current-seconds) 10))
(when (not run)
(BB> "ERROR: NO RUN FOR RUN-ID run-id="run-id)
(BB> "runs-hash-> " (hash-table->alist runs-hash))
|
| ︙ | ︙ | |||
1898 1899 1900 1901 1902 1903 1904 |
tpatt))
"%")))
(item-path (db:test-get-item-path (rmt:get-test-info-by-id run-id test-id)))
(item-test-path (conc test-name "/" (if (equal? item-path "")
"%"
item-path)))
(status-chars (char-set->list (string->char-set status)))
| | | | 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 |
tpatt))
"%")))
(item-path (db:test-get-item-path (rmt:get-test-info-by-id run-id test-id)))
(item-test-path (conc test-name "/" (if (equal? item-path "")
"%"
item-path)))
(status-chars (char-set->list (string->char-set status)))
(testpanel-cmd (conc toolpath " -test " (dboard:tabdat-curr-run-id tabdat) "," test-id " &")))
(BB> "testpanel-cmd=>"testpanel-cmd"< status=>"status"<")
(BB> "test-id="test-id )
;;(BB> " run-id="run-id)
(when (member #\1 status-chars) ;; 1 is left mouse button
(system testpanel-cmd))
(when (member #\2 status-chars) ;; 2 is middle mouse button
|
| ︙ | ︙ |